[PATCH] D14135: sanitizer_common: be more verbose, when symbolizer is not found.

Ivan Krasin via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 12:01:47 PDT 2015


krasin updated this revision to Diff 38678.
krasin added a comment.

reduce scope


http://reviews.llvm.org/D14135

Files:
  lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc

Index: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
===================================================================
--- lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
+++ lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
@@ -446,14 +446,16 @@
 
   if (SymbolizerTool *tool = ChooseExternalSymbolizer(allocator)) {
     list->push_back(tool);
-  } else {
-    VReport(2, "No internal or external symbolizer found.\n");
   }
 
 #if SANITIZER_MAC
   VReport(2, "Using dladdr symbolizer.\n");
   list->push_back(new(*allocator) DlAddrSymbolizer());
 #endif  // SANITIZER_MAC
+
+  if (list->size() == 0) {
+    Report("WARNING: no internal or external symbolizer found.\n");
+  }
 }
 
 Symbolizer *Symbolizer::PlatformInit() {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14135.38678.patch
Type: text/x-patch
Size: 761 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151028/13d8a801/attachment.bin>


More information about the llvm-commits mailing list