[PATCH] D14135: sanitizer_common: be more verbose, when symbolizer is not found.

[Alexey Samsonov via llvm-commits]

samsonov added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:386
@@ -385,3 +385,3 @@
   if (path && path[0] == '\0') {
-    VReport(2, "External symbolizer is explicitly disabled.\n");
+    Report("WARNING: External symbolizer is explicitly disabled.\n");
     return nullptr;
----------------
This is sort of inconsistent - we use VReport(2) if ASAN_OPTIONS=symbolize=0 is used, for example.

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:466
@@ -462,3 +465,3 @@
   ChooseSymbolizerTools(&list, &symbolizer_allocator_);
   return new(symbolizer_allocator_) Symbolizer(list);
 }
----------------
Don't you need to print error message only if symbolizer list is empty? E.g. it's perfectly fine if we weren't able to find external symbolizer, but internal symbolizer (which takes precedence) is used.


http://reviews.llvm.org/D14135