[PATCH] D14141: [1/4] SP and PC as shifted-reg operands are unpredictable in ARMv7 Thumb

[A. Skrobov via llvm-commits]

tyomitch added inline comments.

================
Comment at: test/MC/ARM/thumb2-diagnostics.s:95
@@ +94,3 @@
+
+        @ PC is not valid as shifted-rGPR
+        sbc.w r2, r7, pc, lsr #16
----------------
rengolin wrote:
> Also add a test for SP on ARMv8.
Actually, I'm adding such a test in http://reviews.llvm.org/D14142#inline-115599 -- the motivation being that this test file checks encodings invalid  both in ARMv7 and in ARMv8, while test/MC/ARM/basic-thumb2-instructions-v8.s checks encodings invalid in ARMv7 but valid in ARMv8.

Should I move that hunk into this patch?


http://reviews.llvm.org/D14141