[PATCH] D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825.

A. Skrobov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 13:10:19 PDT 2015


tyomitch added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2332
@@ -2331,1 +2331,3 @@
   // sdiv, srem -> sdivrem
+  // Return DIVREM only if isIntDivCheap() is true.  Otherwise, we break the
+  // simplification logic in visitREM().
----------------
I don't understand this comment. In particular, the code following the comment doesn't check for isIntDivCheap() before returning DIVREM. Is this intended as a FIXME: ?


http://reviews.llvm.org/D14035





More information about the llvm-commits mailing list