[PATCH] D14035: Fix llc crash processing S/UREM for -Oz builds caused by rL250825.

Steve King via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 10:19:47 PDT 2015


srking removed rL LLVM as the repository for this revision.
srking updated this revision to Diff 38430.
srking added a comment.

Moved test to X86 directory and added new test functions without minsize attribute.  X86 is a better home for the test since X86 returns different values for isIntDivCheap() depending on the minsize attribute.
Verified the test catches the crash bug when the s/urem fix is not in place.
Verified all tests pass with the fix.

By design, the test does not care how rem and div are eventually lowered, only that lowering does not cause node corruption.


http://reviews.llvm.org/D14035

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/X86/rem_crash.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14035.38430.patch
Type: text/x-patch
Size: 6983 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151026/028437cc/attachment.bin>


More information about the llvm-commits mailing list