[PATCH] D13958: Mere SHF_STRING

[Rafael Espíndola via llvm-commits]

>> Do you really need this cache? StringTableBuilder now provides a map from stringRef to its offset in the section, so this seems to be redundant.
> Good question.
>
> This is in MergeOutputSection, which handles non string cases, so it is currently not a cache.
>
> It might be possible to view non string merging as a special case of string merging since strings are what take most of the time. Let me give that a try.

Unfortunately the existing StringTableBuilder assumes null
termination, so we can't use it as a general case. I did implement a
more general solution when trying to optimize it. I will give it a
try.

On your question on needing MergeInputSectionBase:  I think I need it.
It holds the Offsets vector on which we binary search.

Cheers,
Rafael