[PATCH] D13958: Mere SHF_STRING

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: ELF/OutputSections.h:255
@@ -253,2 +254,3 @@
   // if so, at what offset it is.
-  llvm::MapVector<ArrayRef<uint8_t>, uintX_t> Offsets;
+  llvm::MapVector<StringRef, uintX_t> Offsets;
+};
----------------
ruiu wrote:
> Do you really need this cache? StringTableBuilder now provides a map from stringRef to its offset in the section, so this seems to be redundant.
Good question.

This is in MergeOutputSection, which handles non string cases, so it is currently not a cache.

It might be possible to view non string merging as a special case of string merging since strings are what take most of the time. Let me give that a try.


http://reviews.llvm.org/D13958