[PATCH] D13642: [Bugpoint] Allow fallback to clang

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 06:02:51 PDT 2015


>> +  // Try to fall-back to clang if the user didn't pass GCC as option.
>> +  if (GCCBinary == "")
>> +    GCCBinary = "clang";
>> +

I was actually thinking of

 if (GCCBinary.empty()) {
  if (gcc exists)
    GCCBinary = "gcc";
  else
    GCCBinary = "clang";
}

> This is still a little bit weird because all the variables have GCC as prefix.
> If you're fine with this, I'll do a sweep and rename all of them. I
> thought about 'CCBinary, class CC' rather than 'GCCBinary, class GCC'
> etc.. but I'm open to new suggestions.

It is OK to rename it, but lets do it in another patch.

Cheers,
Rafael


More information about the llvm-commits mailing list