[PATCH] D13642: [Bugpoint] Allow fallback to clang
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 13 17:50:45 PDT 2015
On Tue, Oct 13, 2015 at 5:48 PM, Davide Italiano via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> davide removed rL LLVM as the repository for this revision.
> davide updated this revision to Diff 37305.
> davide added a comment.
>
> I think your idea is much better, thanks.
>
>
> http://reviews.llvm.org/D13642
>
> Files:
> tools/bugpoint/ExecutionDriver.cpp
>
> Index: tools/bugpoint/ExecutionDriver.cpp
> ===================================================================
> --- tools/bugpoint/ExecutionDriver.cpp
> +++ tools/bugpoint/ExecutionDriver.cpp
> @@ -124,7 +124,7 @@
> cl::ZeroOrMore, cl::PositionalEatsArgs);
>
> cl::opt<std::string>
> - GCCBinary("gcc", cl::init("gcc"),
> + GCCBinary("gcc", cl::init(""),
> cl::desc("The gcc binary to use. (default 'gcc')"));
>
> cl::list<std::string>
> @@ -148,6 +148,10 @@
> SafeInterpreter = nullptr;
> std::string Message;
>
> + // Try to fall-back to clang if the user didn't pass GCC as option.
> + if (GCCBinary == "")
> + GCCBinary = "clang";
> +
This is still a little bit weird because all the variables have GCC as prefix.
If you're fine with this, I'll do a sweep and rename all of them. I
thought about 'CCBinary, class CC' rather than 'GCCBinary, class GCC'
etc.. but I'm open to new suggestions.
--
Davide
"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare
More information about the llvm-commits
mailing list