[PATCH] D13615: [lld][elf2] Local Dynamic TLS

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Target.cpp:372
@@ -360,2 +371,3 @@
+int MipsTargetInfo::relocNeedsGot(uint32_t Type, const SymbolBody &S) const {
   return false;
 }
----------------
rafael wrote:
> Please update this. Depending on false -> 0 is just bad.
> 
> You probably also want to rename the function.
I don't think we need to return int in the first place as the number of got slots a symbol needs can be inferred from the symbol type, as I wrote in the review comment.


http://reviews.llvm.org/D13615