[PATCH] D13615: [lld][elf2] Local Dynamic TLS

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a comment.

This also needs to be rebased.


================
Comment at: ELF/Target.cpp:372
@@ -360,2 +371,3 @@
+int MipsTargetInfo::relocNeedsGot(uint32_t Type, const SymbolBody &S) const {
   return false;
 }
----------------
Please update this. Depending on false -> 0 is just bad.

You probably also want to rename the function.

================
Comment at: ELF/Writer.cpp:294
@@ +293,3 @@
+    uintX_t Flags = Sec->getFlags();
+    // The TLS initialization block goes at the start of the read/write PT_LOAD
+    // as it needs to first be loaded into memory so relocations can be applied.
----------------
Sorry, but why exactly does it need to be at the start of the PT_LOAD? We need to have a single PT_TLS ,but that would still be the case with us having

* Some stuff
* TLS stuff
* Some other stuff



http://reviews.llvm.org/D13615