[llvm] r250204 - Update the branch weight metadata in JumpThreading pass.

Cong Hou via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 12:51:12 PDT 2015


Sure. Thanks for the advice!

thanks,
Cong

On Tue, Oct 13, 2015 at 12:01 PM, Diego Novillo <dnovillo at google.com> wrote:

>
>
> On Tue, Oct 13, 2015 at 11:58 AM, Cong Hou <congh at google.com> wrote:
>
>> r250089 led to some PGO test failures and was reverted by Manman Ren. I
>> investigated this issue and found that I need to make sure the sum of
>> weights won't be zero after normalization. As this is a quick and simple
>> fix, I just resubmitted the patch again with the fix. The weight
>> normalization will be obsoleted soon with one of my patches.
>>
>
> OK, thanks.  For future instances, could you add a note to the second
> patch stating what was fixed in between?  Helps when going through the logs.
>
>
> Diego.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151013/4d91079c/attachment.html>


More information about the llvm-commits mailing list