[PATCH] D13360: [llvm-objdump] Teach -d about AArch64 mapping symbols

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 08:39:22 PDT 2015


davide added inline comments.

================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:988
@@ +987,3 @@
+      // Mapping symbols.
+      if (Symbols[si].second.startswith("$d")) {
+        DataInCode = true;
----------------
jmolloy wrote:
> As this is a target-independent file, shouldn't we also make sure $a and $t (for AArch32) are covered here? Are you going to do this in another patch?
Hi James, I think I can take of this separately. Please file a PR and assign to me so I won't forget.

Thanks,

--
Davide


http://reviews.llvm.org/D13360





More information about the llvm-commits mailing list