[PATCH] D13360: [llvm-objdump] Teach -d about AArch64 mapping symbols

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 08:29:45 PDT 2015


On 7 October 2015 at 11:25, James Molloy <james.molloy at arm.com> wrote:
> jmolloy added a subscriber: jmolloy.
>
> ================
> Comment at: tools/llvm-objdump/llvm-objdump.cpp:988
> @@ +987,3 @@
> +      // Mapping symbols.
> +      if (Symbols[si].second.startswith("$d")) {
> +        DataInCode = true;
> ----------------
> As this is a target-independent file, shouldn't we also make sure $a and $t (for AArch32) are covered here? Are you going to do this in another patch?

It really should be in another patch as that would need a new testcase.


More information about the llvm-commits mailing list