[PATCH] D13188: [MachO] Stop generating *coal* sections.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 12:40:19 PDT 2015


> I think I need more clarification to understand what you are suggesting.
>
> Do you mean we don't need to use shared_ptr after we make changes to use BumpPtrAllocator for MCFragments?

Correct. The reason we have

  // Call the destructors so the fragments are freed
  for (auto &I : ELFUniquingMap)
    I.second->~MCSectionELF();
  for (auto &I : COFFUniquingMap)
    I.second->~MCSectionCOFF();
  for (auto &I : MachOUniquingMap)
    I.second->~MCSectionMachO();

Is to avoid leaking the fragments.

Cheers,
Rafael


More information about the llvm-commits mailing list