[PATCH] D13188: [MachO] Stop generating *coal* sections.
Akira Hatanaka via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 6 12:25:23 PDT 2015
ahatanak added inline comments.
================
Comment at: include/llvm/MC/MCContext.h:204
@@ +203,3 @@
+ /// section.
+ StringMap<std::shared_ptr<MCSectionMachO>> MachOUniquingMap;
+
----------------
rafael wrote:
> This is needed because we pool allocate sections, but not fragments and then have to manually call the section destructors.
>
> Could you try pool allocating the fragments first? There are way more fragments than sections, so this would be a good change anyway.
I think I need more clarification to understand what you are suggesting.
Do you mean we don't need to use shared_ptr after we make changes to use BumpPtrAllocator for MCFragments?
http://reviews.llvm.org/D13188
More information about the llvm-commits
mailing list