[PATCH] D13355: [ELF2] --no-undefined flag implemented

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 10:58:06 PDT 2015


grimar added inline comments.

================
Comment at: ELF/Options.td:41
@@ +40,3 @@
+    : Flag<["--"], "no-undefined">,
+      HelpText<"Report unresolved symbol references from regular object files "
+               "even if the linker is creating a non-symbolic shared library.">;
----------------
ruiu wrote:
> ruiu wrote:
> > Indentation error.
> Let's make the message a bit shorter: "Report unresolved symbols even if the linker is creating a shared library"
> 
> Do not put period at end as other messages don't.
Thats how clang-format handles it i believe. But after your comments I understood that  it is not supposed to be used in this file :)


http://reviews.llvm.org/D13355





More information about the llvm-commits mailing list