[PATCH] D13355: [ELF2] --no-undefined flag implemented

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Options.td:39
@@ -38,1 +38,3 @@
 
+def no_undefined
+    : Flag<["--"], "no-undefined">,
----------------
Remove the newline at end of this line for consistency with other `def`s.

================
Comment at: ELF/Options.td:41
@@ +40,3 @@
+    : Flag<["--"], "no-undefined">,
+      HelpText<"Report unresolved symbol references from regular object files "
+               "even if the linker is creating a non-symbolic shared library.">;
----------------
Indentation error.

================
Comment at: ELF/Options.td:41-43
@@ -39,1 +40,5 @@
+    : Flag<["--"], "no-undefined">,
+      HelpText<"Report unresolved symbol references from regular object files "
+               "even if the linker is creating a non-symbolic shared library.">;
+
 def output : Separate<["-"], "o">, MetaVarName<"<path>">,
----------------
ruiu wrote:
> Indentation error.
Let's make the message a bit shorter: "Report unresolved symbols even if the linker is creating a shared library"

Do not put period at end as other messages don't.

================
Comment at: test/elf2/no-undefined.s:5-10
@@ +4,8 @@
+
+# Try to make a DSO that links to another DSO with unresolved. 
+# Specify --no-undefined and that should not fail because this flag
+# does not control the behaviour for reporting unresolved references
+# found in shared libraries being linked in.
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/no-undefined.s -o %t2
+# RUN: lld -shared --no-undefined -flavor gnu2 %t2 %t1.so -o %t3.so
+
----------------
I don't think we really have to test this case. Let's remove that and no-undefined.s.


http://reviews.llvm.org/D13355