[lld] r249016 - ELF2: Rename undefError -> reportUndefined.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 07:46:55 PDT 2015


Author: ruiu
Date: Thu Oct  1 09:46:54 2015
New Revision: 249016

URL: http://llvm.org/viewvc/llvm-project?rev=249016&view=rev
Log:
ELF2: Rename undefError -> reportUndefined.

The new name starts with a verb, and it does not imply that it errors
out and exit (it acutally can just emit a warning depending on settings.)

Modified:
    lld/trunk/ELF/Writer.cpp

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=249016&r1=249015&r2=249016&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Thu Oct  1 09:46:54 2015
@@ -267,7 +267,7 @@ void Writer<ELFT>::scanRelocs(const Inpu
 }
 
 template <class ELFT>
-static void undefError(const SymbolTable &S, const SymbolBody &Sym) {
+static void reportUndefined(const SymbolTable &S, const SymbolBody &Sym) {
   typedef typename ELFFile<ELFT>::Elf_Sym Elf_Sym;
   typedef typename ELFFile<ELFT>::Elf_Sym_Range Elf_Sym_Range;
 
@@ -337,7 +337,7 @@ template <class ELFT> void Writer<ELFT>:
     StringRef Name = P.first;
     SymbolBody *Body = P.second->Body;
     if (Body->isStrongUndefined())
-      undefError<ELFT>(Symtab, *Body);
+      reportUndefined<ELFT>(Symtab, *Body);
 
     if (auto *C = dyn_cast<DefinedCommon<ELFT>>(Body))
       CommonSymbols.push_back(C);




More information about the llvm-commits mailing list