[llvm] r248963 - Enable -Wdeprecated in the cmake build now that LLVM (& Clang, Polly, and LLD) are -Wdeprecated clean

[David Blaikie via llvm-commits]

Reverted in 248972 pending investigation about buildbots with problematic
standard libraries.

On Wed, Sep 30, 2015 at 4:36 PM, David Blaikie via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: dblaikie
> Date: Wed Sep 30 18:36:12 2015
> New Revision: 248963
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248963&view=rev
> Log:
> Enable -Wdeprecated in the cmake build now that LLVM (& Clang, Polly, and
> LLD) are -Wdeprecated clean
>
> This particularly helps enforce the C++ Rule of 5 (for new move ops this
> is already an error, but for a type only using C++98 features (copy
> ctor/assign, dtor) it is only deprecated, not invalid)
>
> Applying the flag for any GCC compatible compiler - GCC doesn't warn on
> the Rule of 5 cases that C++11 deprecates, but it doesn't have other
> false positives so far as I could see (compiling with GCC 4.8 didn't
> produce any -Wdeprecated warnings I could spot).
>
> Reviewers: aaron.ballman
>
> Differential Revision: http://reviews.llvm.org/D13314
>
> Modified:
>     llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
>
> Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=248963&r1=248962&r2=248963&view=diff
>
> ==============================================================================
> --- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
> +++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Wed Sep 30 18:36:12
> 2015
> @@ -364,7 +364,7 @@ if( MSVC )
>
>  elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE )
>    if (LLVM_ENABLE_WARNINGS)
> -    append("-Wall -W -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS
> CMAKE_CXX_FLAGS)
> +    append("-Wall -W -Wno-unused-parameter -Wwrite-strings -Wdeprecated"
> CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
>      append("-Wcast-qual" CMAKE_CXX_FLAGS)
>
>      # Turn off missing field initializer warnings for gcc to avoid noise
> from
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150930/0f43f236/attachment.html>