<div dir="ltr">Reverted in <span style="font-family:monospace">248972 pending investigation about buildbots with problematic standard libraries.</span></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 30, 2015 at 4:36 PM, David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dblaikie<br>
Date: Wed Sep 30 18:36:12 2015<br>
New Revision: 248963<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=248963&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=248963&view=rev</a><br>
Log:<br>
Enable -Wdeprecated in the cmake build now that LLVM (& Clang, Polly, and LLD) are -Wdeprecated clean<br>
<br>
This particularly helps enforce the C++ Rule of 5 (for new move ops this<br>
is already an error, but for a type only using C++98 features (copy<br>
ctor/assign, dtor) it is only deprecated, not invalid)<br>
<br>
Applying the flag for any GCC compatible compiler - GCC doesn't warn on<br>
the Rule of 5 cases that C++11 deprecates, but it doesn't have other<br>
false positives so far as I could see (compiling with GCC 4.8 didn't<br>
produce any -Wdeprecated warnings I could spot).<br>
<br>
Reviewers: aaron.ballman<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D13314" rel="noreferrer" target="_blank">http://reviews.llvm.org/D13314</a><br>
<br>
Modified:<br>
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
<br>
Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=248963&r1=248962&r2=248963&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=248963&r1=248962&r2=248963&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)<br>
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Wed Sep 30 18:36:12 2015<br>
@@ -364,7 +364,7 @@ if( MSVC )<br>
<br>
 elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE )<br>
   if (LLVM_ENABLE_WARNINGS)<br>
-    append("-Wall -W -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)<br>
+    append("-Wall -W -Wno-unused-parameter -Wwrite-strings -Wdeprecated" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)<br>
     append("-Wcast-qual" CMAKE_CXX_FLAGS)<br>
<br>
     # Turn off missing field initializer warnings for gcc to avoid noise from<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>