[PATCH] D13156: Fix performance problem in long-running SectionMemoryManagers

[Philip Reames via llvm-commits]

reames added inline comments.

================
Comment at: lib/ExecutionEngine/SectionMemoryManager.cpp:169
@@ -161,3 +168,3 @@
   for (MemoryGroup *Group : {&CodeMem, &RWDataMem, &RODataMem})
     for (sys::MemoryBlock &Block : Group->AllocatedMem)
       sys::Memory::releaseMappedMemory(Block);
----------------
loladiro wrote:
> reames wrote:
> > I think you need to extend the destructor to handle the case where the memory manager is destructed before finalization.  
> Thanks! I guess we also need to release the `FreeMem` blocks in here then.
Nope.  Be careful with this.  FreeMem appears to point inside regions tracked by AllocatedMem


Repository:
  rL LLVM

http://reviews.llvm.org/D13156