[PATCH] D13156: Fix performance problem in long-running SectionMemoryManagers
Keno Fischer via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 30 11:34:38 PDT 2015
loladiro added inline comments.
================
Comment at: lib/ExecutionEngine/SectionMemoryManager.cpp:169
@@ -161,3 +168,3 @@
for (MemoryGroup *Group : {&CodeMem, &RWDataMem, &RODataMem})
for (sys::MemoryBlock &Block : Group->AllocatedMem)
sys::Memory::releaseMappedMemory(Block);
----------------
reames wrote:
> I think you need to extend the destructor to handle the case where the memory manager is destructed before finalization.
Thanks! I guess we also need to release the `FreeMem` blocks in here then.
Repository:
rL LLVM
http://reviews.llvm.org/D13156
More information about the llvm-commits
mailing list