[polly] r248823 - Replace default destructors by {} destructors

[David Blaikie via llvm-commits]

On Tue, Sep 29, 2015 at 12:54 PM, Tobias Grosser via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: grosser
> Date: Tue Sep 29 14:52:09 2015
> New Revision: 248823
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248823&view=rev
> Log:
> Replace default destructors by {} destructors
>
> Hope this fixes the buildbots for now.
>

Oh, sorry about that. Didn't see those buildbot failures.


>
> Modified:
>     polly/trunk/include/polly/CodeGen/BlockGenerators.h
>
> Modified: polly/trunk/include/polly/CodeGen/BlockGenerators.h
> URL:
> http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/CodeGen/BlockGenerators.h?rev=248823&r1=248822&r2=248823&view=diff
>
> ==============================================================================
> --- polly/trunk/include/polly/CodeGen/BlockGenerators.h (original)
> +++ polly/trunk/include/polly/CodeGen/BlockGenerators.h Tue Sep 29
> 14:52:09 2015
> @@ -161,7 +161,7 @@ public:
>    void finalizeSCoP(Scop &S);
>
>    /// @brief An empty destructor
> -  virtual ~BlockGenerator() = default;
> +  virtual ~BlockGenerator(){};
>

Probably want to drop the spurious semicolon from the end of this function,
and of the RegionGenerator's dtor too.


>
>    BlockGenerator(const BlockGenerator &) = default;
>
> @@ -687,7 +687,7 @@ public:
>    /// @param BlockGen A generator for basic blocks.
>    RegionGenerator(BlockGenerator &BlockGen) : BlockGenerator(BlockGen) {}
>
> -  virtual ~RegionGenerator() = default;
> +  virtual ~RegionGenerator(){};
>

You can probably remove this dtor entirely - the implicit/default should be
fine (the base class's dtor is already virtual, so the derived class's
implicit dtor will be virtual)


>
>    /// @brief Copy the region statement @p Stmt.
>    ///
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150929/94a66910/attachment.html>