<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 29, 2015 at 12:54 PM, Tobias Grosser via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grosser<br>
Date: Tue Sep 29 14:52:09 2015<br>
New Revision: 248823<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=248823&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=248823&view=rev</a><br>
Log:<br>
Replace default destructors by {} destructors<br>
<br>
Hope this fixes the buildbots for now.<br></blockquote><div><br></div><div>Oh, sorry about that. Didn't see those buildbot failures.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    polly/trunk/include/polly/CodeGen/BlockGenerators.h<br>
<br>
Modified: polly/trunk/include/polly/CodeGen/BlockGenerators.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/CodeGen/BlockGenerators.h?rev=248823&r1=248822&r2=248823&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/CodeGen/BlockGenerators.h?rev=248823&r1=248822&r2=248823&view=diff</a><br>
==============================================================================<br>
--- polly/trunk/include/polly/CodeGen/BlockGenerators.h (original)<br>
+++ polly/trunk/include/polly/CodeGen/BlockGenerators.h Tue Sep 29 14:52:09 2015<br>
@@ -161,7 +161,7 @@ public:<br>
   void finalizeSCoP(Scop &S);<br>
<br>
   /// @brief An empty destructor<br>
-  virtual ~BlockGenerator() = default;<br>
+  virtual ~BlockGenerator(){};<br></blockquote><div><br></div><div>Probably want to drop the spurious semicolon from the end of this function, and of the RegionGenerator's dtor too.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   BlockGenerator(const BlockGenerator &) = default;<br>
<br>
@@ -687,7 +687,7 @@ public:<br>
   /// @param BlockGen A generator for basic blocks.<br>
   RegionGenerator(BlockGenerator &BlockGen) : BlockGenerator(BlockGen) {}<br>
<br>
-  virtual ~RegionGenerator() = default;<br>
+  virtual ~RegionGenerator(){};<br></blockquote><div><br></div><div>You can probably remove this dtor entirely - the implicit/default should be fine (the base class's dtor is already virtual, so the derived class's implicit dtor will be virtual)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   /// @brief Copy the region statement @p Stmt.<br>
   ///<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>