[PATCH] D13232: ELF2: Add basic linker script support.

[Rui Ueyama via llvm-commits]

On Mon, Sep 28, 2015 at 10:35 PM, Sean Silva <chisophugis at gmail.com> wrote:

> silvas added inline comments.
>
> ================
> Comment at: test/elf2/invalid-elf.test:1-8
> @@ -1,9 +1,1 @@
> -RUN: not lld -flavor gnu2 %p/Inputs/invalid-data-encoding.elf -o %t2 2>&1
> | \
> -RUN:   FileCheck --check-prefix=INVALID-DATA-ENC %s
> -INVALID-DATA-ENC: Invalid data encoding: {{.*}}/invalid-data-encoding.elf
> -
> -RUN: not lld -flavor gnu2 %p/Inputs/invalid-file-class.elf -o %t2 2>&1 | \
> -RUN:   FileCheck --check-prefix=INVALID-FILE-CLASS %s
> -INVALID-FILE-CLASS: Invalid file class: {{.*}}/invalid-file-class.elf
> -
>  RUN: not lld -flavor gnu2 %p/Inputs/invalid-symtab-sh_info.elf -o %t2
> 2>&1 | \
> ----------------
> But you did not remove the place where we print the error message. Should
> we convert the error messages into assertions?
>

Good point. We should remove that code. I'll do.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150929/27ee363c/attachment.html>