[PATCH] D13232: ELF2: Add basic linker script support.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 22:35:43 PDT 2015


silvas added inline comments.

================
Comment at: test/elf2/invalid-elf.test:1-8
@@ -1,9 +1,1 @@
-RUN: not lld -flavor gnu2 %p/Inputs/invalid-data-encoding.elf -o %t2 2>&1 | \
-RUN:   FileCheck --check-prefix=INVALID-DATA-ENC %s
-INVALID-DATA-ENC: Invalid data encoding: {{.*}}/invalid-data-encoding.elf
-
-RUN: not lld -flavor gnu2 %p/Inputs/invalid-file-class.elf -o %t2 2>&1 | \
-RUN:   FileCheck --check-prefix=INVALID-FILE-CLASS %s
-INVALID-FILE-CLASS: Invalid file class: {{.*}}/invalid-file-class.elf
-
 RUN: not lld -flavor gnu2 %p/Inputs/invalid-symtab-sh_info.elf -o %t2 2>&1 | \
----------------
But you did not remove the place where we print the error message. Should we convert the error messages into assertions?


http://reviews.llvm.org/D13232





More information about the llvm-commits mailing list