[PATCH] D13212: [ELF2] - Implemented -e flag

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Config.h:28
@@ -27,2 +27,3 @@
   bool NoInhibitExec = false;
+  llvm::StringRef EntryPoint = "_start";
 };
----------------
ruiu wrote:
> Member variable names in this class are consistent with their corresponding command line options. s/EntryPoint/Entry/.
Ok. That was not obvious though.

================
Comment at: ELF/Driver.cpp:100
@@ -99,1 +99,3 @@
 
+  // Handle -e
+  if (auto *Arg = Args.getLastArg(OPT_e))
----------------
ruiu wrote:
> We don't have comments for other options above.
I`ll remove if you wish. Other are self-explaining, I thought at least reference to "-e" makes it more clear.


http://reviews.llvm.org/D13212