[PATCH] D13212: [ELF2] - Implemented -e flag

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 06:42:05 PDT 2015


ruiu added inline comments.

================
Comment at: ELF/Config.h:28
@@ -27,2 +27,3 @@
   bool NoInhibitExec = false;
+  llvm::StringRef EntryPoint = "_start";
 };
----------------
Member variable names in this class are consistent with their corresponding command line options. s/EntryPoint/Entry/.

================
Comment at: ELF/Driver.cpp:100
@@ -99,1 +99,3 @@
 
+  // Handle -e
+  if (auto *Arg = Args.getLastArg(OPT_e))
----------------
We don't have comments for other options above.

================
Comment at: test/elf2/entry.s:7
@@ +6,2 @@
+_end: 
+
----------------
Remove blank trailing lines.


http://reviews.llvm.org/D13212





More information about the llvm-commits mailing list