[PATCH] D12979: Avoid inlining in exception handling context

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 02:59:06 PDT 2015

hfinkel added a comment.

> For now, I can add FIXME mentioning that Attribute::Cold could be used when the inline cold-threshold is tune.

Please do. Actually, please add both attributes for now and make the FIXME to just use 'cold'. Even if the attribute does not do the right thing in the inliner, it does have the correct affect on MachineBlockPlacement, etc.

Comment at: include/llvm/IR/CallSite.h:274
@@ -273,3 +273,3 @@
-  void setIsNoInline(bool Value = true) {
-    CALLSITE_DELEGATE_SETTER(setIsNoInline(Value));
+  void setIsNoInline() {
Why are you changing this?

Comment at: lib/Transforms/IPO/PruneEH.cpp:79
@@ +78,3 @@
+bool PruneEH::doFinalization(CallGraph &CG) {
+  MarkNoInlineInEHR = false;
Indeed, I agree.


More information about the llvm-commits mailing list