[PATCH] D12979: Avoid inlining in exception handling context

Jun Bum Lim via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 11:37:24 PDT 2015

junbuml added inline comments.

Comment at: lib/Transforms/IPO/PruneEH.cpp:79
@@ +78,3 @@
+bool PruneEH::doFinalization(CallGraph &CG) {
+  MarkNoInlineInEHR = false;
hfinkel wrote:
> As I understand it, you want this flag to apply per-module, not per run over the call graph. So you need to do this in 'bool doFinalization(Module &)', not in 'doFinalization(CallGraph &CG)' which is called at the end of the call graph's runOnModule function. If there's no functional difference, then you don't need the flag at all.
As you mention, doFinalization(CallGraph &CG) is called at the end of runOnModule() of CGPassManager. Since doFinalization(CallGraph &CG) is called after all SCCs in the module has been processed, I believe this is called once per module. 


More information about the llvm-commits mailing list