[PATCH] D12781: PGO IR-level instrumentation infrastructure

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 15:12:25 PDT 2015


The reason I do not call SplitAllCriticalEdges is because I don't want to
split all critical edges. I only split these critical edges that need to be
instrumented. For critical edges, I prioritize them into MST to avoid the
split.

-Rong

On Tue, Sep 22, 2015 at 11:44 PM, Kostya Serebryany <kcc at google.com> wrote:

> kcc added a comment.
>
> \> - is there a reason that this is breaking critical edges itself instead
> of using break-crit-edges pass? Is break-crit-edges dead? SanitizerCoverage
> doesn't seem to use it either.
>
> SanitizerCoverage uses SplitAllCriticalEdges from
> include/llvm/Transforms/Utils/BasicBlockUtils.h
>
>
> http://reviews.llvm.org/D12781
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150923/d716ff20/attachment.html>


More information about the llvm-commits mailing list