<div dir="ltr">The reason I do not call SplitAllCriticalEdges is because I don't want to split all critical edges. I only split these critical edges that need to be instrumented. For critical edges, I prioritize them into MST to avoid the split.<div><br></div><div>-Rong<br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 22, 2015 at 11:44 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">kcc added a comment.<br>
<br>
\> - is there a reason that this is breaking critical edges itself instead of using break-crit-edges pass? Is break-crit-edges dead? SanitizerCoverage doesn't seem to use it either.<br>
<br>
SanitizerCoverage uses SplitAllCriticalEdges from include/llvm/Transforms/Utils/BasicBlockUtils.h<br>
<br>
<br>
<a href="http://reviews.llvm.org/D12781" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12781</a><br>
<br>
<br>
<br>
</blockquote></div><br></div></div></div>