[PATCH] D13055: [ELF2] Handle -m option

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 09:03:18 PDT 2015


rafael added inline comments.

================
Comment at: ELF/Driver.cpp:18
@@ -17,2 +17,3 @@
 #include "llvm/ADT/StringExtras.h"
+#include "llvm/Object/ELF.h"
 #include "llvm/Support/FileSystem.h"
----------------
Unnecessary.

================
Comment at: ELF/Driver.cpp:40
@@ +39,3 @@
+namespace {
+using namespace ELF;
+
----------------
Replace this with a

using namespace llvm::ELF;

just after the existing

using namespace llvm;

================
Comment at: ELF/Driver.cpp:80
@@ +79,3 @@
+
+static inline void configureTarget(ELFKind ElfKind, uint16_t EMachine) {
+  Config->ElfKind = ElfKind;
----------------
Drop the inline.


http://reviews.llvm.org/D13055





More information about the llvm-commits mailing list