[PATCH] D13055: [ELF2] Handle -m option

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: ELF/Config.h:14
@@ -13,1 +13,3 @@
 #include "llvm/ADT/StringRef.h"
+#include "llvm/Object/ELF.h"
+#include <cstdint>
----------------
You only need Support/ELF.h

================
Comment at: ELF/Config.h:15
@@ -14,1 +14,3 @@
+#include "llvm/Object/ELF.h"
+#include <cstdint>
 
----------------
Not used


================
Comment at: ELF/Config.h:35
@@ +34,3 @@
+
+  ELFKind ElfKind = ELF64LEKind;
+  uint16_t EMachine = llvm::ELF::EM_X86_64;
----------------
Can these two variables be left uninitialized? If not, please make them an explicit Optional<>. We really should not give EM_X86_64 or ELF64LE any special treatment.

================
Comment at: ELF/SymbolTable.cpp:25
@@ -24,2 +24,3 @@
 
 bool SymbolTable::shouldUseRela() const {
+  return Config->is64Bits();
----------------
git-clang-format


http://reviews.llvm.org/D13055