[PATCH] D12979: Avoid inlining in exception handling context

[David Majnemer via llvm-commits]

majnemer added a subscriber: majnemer.

================
Comment at: lib/Transforms/IPO/PruneEH.cpp:47
@@ -44,1 +46,3 @@
+
+    PruneEH() : CallGraphSCCPass(ID), MarkNoInlineInEHR (false) {
       initializePruneEHPass(*PassRegistry::getPassRegistry());
----------------
Please do not have a space between the variable and the parenthesis.

================
Comment at: lib/Transforms/IPO/PruneEH.cpp:313
@@ +312,3 @@
+  for (User *AllocU : EHAlloc->users()) {
+    if (BitCastInst *BCInst = dyn_cast<BitCastInst>(AllocU))
+      AddNoInlineForEHAllocUsers(BCInst, EHAllocCall);
----------------
majnemer wrote:
> Please use consistent bracing.
You can use `auto *BCInst` to avoid repetition.

================
Comment at: lib/Transforms/IPO/PruneEH.cpp:313-315
@@ +312,5 @@
+  for (User *AllocU : EHAlloc->users()) {
+    if (BitCastInst *BCInst = dyn_cast<BitCastInst>(AllocU))
+      AddNoInlineForEHAllocUsers(BCInst, EHAllocCall);
+    else {
+      CallSite CS(AllocU);
----------------
Please use consistent bracing.


http://reviews.llvm.org/D12979