[PATCH] D12979: Avoid inlining in exception handling context
Jun Bum Lim via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 23 08:20:12 PDT 2015
junbuml added a comment.
Addressed comments from Hal.
Thanks Hal for the review!
================
Comment at: lib/Transforms/IPO/PruneEH.cpp:326
@@ +325,3 @@
+ for (User *CallU : EHAllocCall->users()) {
+ BitCastInst *BCInst = dyn_cast<BitCastInst>(CallU);
+ if (!BCInst)
----------------
hfinkel wrote:
> There's no need to require the bitcast here. What if you actually want an i8* as the exception type? You should just call stripPointerCasts instead.
>
Thanks Hal for the review.
I refactor this part into a separate function to trace bitcast from __cxa_allocate_exception().
http://reviews.llvm.org/D12979
More information about the llvm-commits
mailing list