[PATCH] D12637: [InstCombine] Recognize another bswap idiom.
David Majnemer via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 23 08:34:20 PDT 2015
majnemer added a comment.
In my experience
In http://reviews.llvm.org/D12637#251754, @chatur01 wrote:
> > I'm confused as to why this needs any target specific tests. This is a change to IR canonicalization.
> I was confused about that too, but I was attempting to address this review comment:
> > Are there tests to make sure that this built-in expands to the correct instructions in the different types of ARM architectures? If not, I'd add that, too.
> Hopefully I won't be asked to go through the other backends as well now! :)
Backends are expected to do intelligent things with `llvm.bswap`, I don't think the burden is on you to make sure they aren't doing the wrong thing.
More information about the llvm-commits