[PATCH] D12637: [InstCombine] Recognize another bswap idiom.

Charlie Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 08:09:07 PDT 2015

chatur01 added a comment.

> I'm confused as to why this needs any target specific tests. This is a change to IR canonicalization.

I was confused about that too, but I was attempting to address this review comment:

> Are there tests to make sure that this built-in expands to the correct instructions in the different types of ARM architectures? If not, I'd add that, too.

Hopefully I won't be asked to go through the other backends as well now! :)


More information about the llvm-commits mailing list