[PATCH] D12937: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 16:49:28 PDT 2015

rengolin added a comment.

In http://reviews.llvm.org/D12937#250486, @psmith wrote:

> I think it is probably the least worst solution right now. I'm happy to proceed.

I'd like to at least know how widespread is this option and who actually uses it. I'd seriously like to consider deprecating it and calling just "dsp".

> Another possible alternative is to add a FeatureDSP, that FeatureDSPThumb2 maps on to. However I don't think that using up another SubTargetFeature is necessarily a good trade off either.

We could easily just change the internal table-gen feature name to FeatureDSP, and make the enum tag name just DSP and keep only the clang string t2dsp, and put a warning on the next release notes that we'll deprecate it on the next++.



More information about the llvm-commits mailing list