[PATCH] D12937: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 09:26:09 PDT 2015

jmolloy added a comment.

Hi Artyom,

Some comments below.


Comment at: llvm/trunk/lib/Support/TargetParser.cpp:193
@@ +192,3 @@
+  if (Extensions & ARM::AEK_T2DSP)
+    Features.push_back("+t2dsp");
Why aren't you adding -t2dsp otherwise, like the other features in this file?

Comment at: llvm/trunk/lib/Target/ARM/ARM.td:122
@@ -121,3 +121,3 @@
-/// Some M architectures don't have the DSP extension (v7E-M vs. v7M)
+/// Some architectures don't have the DSP extension
 def FeatureDSPThumb2 : SubtargetFeature<"t2dsp", "Thumb2DSP", "true",
It doesn't seem obvious to me why this is called "t2dsp" but also affects ARM mode. Therefore a nice comment wouldn't go amiss, because not everyone will have read your email thread.



More information about the llvm-commits mailing list