[PATCH] D13059: [CMake] [Darwin] Bug 21562 - Add a CMake equivalent for make/platform/clang_darwin.mk in compiler_rt

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 15:55:27 PDT 2015

beanz added inline comments.

Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:112
@@ +111,3 @@
+  if(EXISTS ${DARWIN_EXCLUDE_DIR}/${os}-${arch}.txt)
+    file(READ ${DARWIN_EXCLUDE_DIR}/${os}-${arch}.txt ${os}_${arch}_BASE_BUILTINS)
samsonov wrote:
> Instead of duplicating this logic several times and inventing tricky variable names, consider adding a function that would take a filename and a list, and would append all lines from a file to a list (if the file exists).
Sure. Will do.

Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:123
@@ +122,3 @@
+      string(REPLACE "\n" ";" ${arch}_${os}_BUILTINS ${${arch}_${os}_BUILTINS})
+      break()
+    endif()
samsonov wrote:
> So now if you have ios6-armv7.txt and ios7-armv7.txt, you will use the contents of a random file. Is this expected? Shouldn't you add both instead?
It shouldn't be random. It should be the first alphabetically, which is the intent. You only want to exclude symbols in the lowest supported version. Symbols that are present in a later version should be included if you're supporting older versions.

Does that make sense?


More information about the llvm-commits mailing list