[PATCH] D13059: [CMake] [Darwin] Bug 21562 - Add a CMake equivalent for make/platform/clang_darwin.mk in compiler_rt

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 15:50:24 PDT 2015

samsonov added inline comments.

Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:112
@@ +111,3 @@
+  if(EXISTS ${DARWIN_EXCLUDE_DIR}/${os}-${arch}.txt)
+    file(READ ${DARWIN_EXCLUDE_DIR}/${os}-${arch}.txt ${os}_${arch}_BASE_BUILTINS)
Instead of duplicating this logic several times and inventing tricky variable names, consider adding a function that would take a filename and a list, and would append all lines from a file to a list (if the file exists).

Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:123
@@ +122,3 @@
+      string(REPLACE "\n" ";" ${arch}_${os}_BUILTINS ${${arch}_${os}_BUILTINS})
+      break()
+    endif()
So now if you have ios6-armv7.txt and ios7-armv7.txt, you will use the contents of a random file. Is this expected? Shouldn't you add both instead?


More information about the llvm-commits mailing list