[PATCH] D12956: [mips] Allow constant expressions in second argument of .cpsetup.
Vasileios Kalintiris via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 21 02:14:44 PDT 2015
vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.
Comment at: test/MC/Mips/cpsetup.s:36
@@ -33,8 +35,3 @@
-# NXX: sd $gp, 8($sp)
-# NXX: lui $gp, 0
-# NXX: R_MIPS_GPREL16/R_MIPS_SUB/R_MIPS_HI16 __cerror
-# NXX: addiu $gp, $gp, 0
-# NXX: R_MIPS_GPREL16/R_MIPS_SUB/R_MIPS_LO16 __cerror
-# N32: addu $gp, $gp, $25
-# N64: daddu $gp, $gp, $25
+# NXX-NEXT: sd $gp, 8($sp)
+# NXX-NEXT: lui $gp, 0
It seems that FileCheck does not complain when there's no any previous check line with the same check prefix as the one used with the -NEXT directive. However, could we remove that in order to make explicit the places where we begin to check with a check prefix? There are two-three such cases below too.
More information about the llvm-commits