[PATCH] D12565: SelectionDAGDumper: print datatypes behind node names

[hfinkel@anl.gov via llvm-commits]

hfinkel added a comment.

In http://reviews.llvm.org/D12565#248898, @MatzeB wrote:

> My thinking here was:
>
> - The datatype is just another attribute stored with the node, it is not an attribute of the magic value marker tXX
> - the output is consistent for inlined and non-inlined nodes.
>
>
>
> In http://reviews.llvm.org/D12565#248873, @hfinkel wrote:
>
> > I'm not sure how much I care either way, but can't you just omit the '=' sign when printing the constants inline?
>
>
> Anyway I don't really care either for this (the inline printing is what I care about). So if this won't get a LGTM I'll change it to the suggested variant of just leaving out the equal sign when printing inline.


I think that I'd prefer that. I'm leaning toward saying that the node:type formatting actually makes things more difficult to read.


Repository:
  rL LLVM

http://reviews.llvm.org/D12565