[PATCH] D12565: SelectionDAGDumper: print datatypes behind node names
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 18 11:11:50 PDT 2015
MatzeB added a comment.
My thinking here was:
- The datatype is just another attribute stored with the node, it is not an attribute of the magic value marker tXX
- the output is consistent for inlined and non-inlined nodes.
In http://reviews.llvm.org/D12565#248873, @hfinkel wrote:
> I'm not sure how much I care either way, but can't you just omit the '=' sign when printing the constants inline?
Anyway I don't really care either for this (the inline printing is what I care about). So if this won't get a LGTM I'll change it to the suggested variant of just leaving out the equal sign when printing inline.
Repository:
rL LLVM
http://reviews.llvm.org/D12565
More information about the llvm-commits
mailing list