[lld] r247736 - LTO: Adjust to LLVM r247735

[David Blaikie via llvm-commits]

On Wed, Sep 16, 2015 at 10:51 AM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

>
> > On 2015-Sep-16, at 09:42, David Blaikie <dblaikie at gmail.com> wrote:
> >
> >
> >
> > On Tue, Sep 15, 2015 at 4:06 PM, Duncan P. N. Exon Smith via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
> > Author: dexonsmith
> > Date: Tue Sep 15 18:06:16 2015
> > New Revision: 247736
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=247736&view=rev
> > Log:
> > LTO: Adjust to LLVM r247735
> >
> > Perhaps lld wants to disable the verifier sometimes during COFF LTO, but
> > for now just match behaviour from before r247735.
> >
> > Rui - yeah, you probably want to switch this to disable the extra
> verifier runs. (Duncan: this is just the /extra/ runs, right? Not the input
> verification which is still always-on?)
>
> That's correct.
>
> > I wouldn't mind if this (this set of changes overall) had just changed
> the default to "only verify input in non-debug builds", really.
>
> I don't want the behaviour of llvm-lto (the testing tool) to depend on
> whether we've built in asserts mode.
>

Fair.


>
> >
> > Modified:
> >     lld/trunk/COFF/SymbolTable.cpp
> >
> > Modified: lld/trunk/COFF/SymbolTable.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/SymbolTable.cpp?rev=247736&r1=247735&r2=247736&view=diff
> >
> ==============================================================================
> > --- lld/trunk/COFF/SymbolTable.cpp (original)
> > +++ lld/trunk/COFF/SymbolTable.cpp Tue Sep 15 18:06:16 2015
> > @@ -411,7 +411,7 @@ std::vector<ObjectFile *> SymbolTable::c
> >      CG->addModule(BitcodeFiles[I]->getModule());
> >
> >    std::string ErrMsg;
> > -  if (!CG->optimize(false, false, false, ErrMsg))
> > +  if (!CG->optimize(false, false, false, false, ErrMsg))
> >      error(ErrMsg);
> >
> >    Objs.resize(Config->LTOJobs);
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150916/f7315648/attachment.html>