<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 16, 2015 at 10:51 AM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On 2015-Sep-16, at 09:42, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
> On Tue, Sep 15, 2015 at 4:06 PM, Duncan P. N. Exon Smith via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: dexonsmith<br>
> Date: Tue Sep 15 18:06:16 2015<br>
> New Revision: 247736<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=247736&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=247736&view=rev</a><br>
> Log:<br>
> LTO: Adjust to LLVM r247735<br>
><br>
> Perhaps lld wants to disable the verifier sometimes during COFF LTO, but<br>
> for now just match behaviour from before r247735.<br>
><br>
> Rui - yeah, you probably want to switch this to disable the extra verifier runs. (Duncan: this is just the /extra/ runs, right? Not the input verification which is still always-on?)<br>
<br>
</span>That's correct.<br>
<span class=""><br>
> I wouldn't mind if this (this set of changes overall) had just changed the default to "only verify input in non-debug builds", really.<br>
<br>
</span>I don't want the behaviour of llvm-lto (the testing tool) to depend on<br>
whether we've built in asserts mode.<br></blockquote><div><br>Fair.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
><br>
> Modified:<br>
>     lld/trunk/COFF/SymbolTable.cpp<br>
><br>
> Modified: lld/trunk/COFF/SymbolTable.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/SymbolTable.cpp?rev=247736&r1=247735&r2=247736&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/SymbolTable.cpp?rev=247736&r1=247735&r2=247736&view=diff</a><br>
> ==============================================================================<br>
> --- lld/trunk/COFF/SymbolTable.cpp (original)<br>
> +++ lld/trunk/COFF/SymbolTable.cpp Tue Sep 15 18:06:16 2015<br>
> @@ -411,7 +411,7 @@ std::vector<ObjectFile *> SymbolTable::c<br>
>      CG->addModule(BitcodeFiles[I]->getModule());<br>
><br>
>    std::string ErrMsg;<br>
> -  if (!CG->optimize(false, false, false, ErrMsg))<br>
> +  if (!CG->optimize(false, false, false, false, ErrMsg))<br>
>      error(ErrMsg);<br>
><br>
>    Objs.resize(Config->LTOJobs);<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
</div></div></blockquote></div><br></div></div>