[PATCH] D12709: [PATCH] [sanitizers] [msan] Enable MSAN for aarch64

[Adhemerval Zanella via llvm-commits]

zatrazz added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:332
@@ -323,1 +331,3 @@
+#endif
+#if defined(PT_GETREGS) && defined(PT_SETREGS)
   int ptrace_getfpregs = PTRACE_GETFPREGS;
----------------
eugenis wrote:
> did you mean PT_GETFPREGS here and PT_GETFPXREGS below?
Yes and '#if defined(PT_GETFPXREGS) && defined(PT_SETFPXREGS)' below as well. I will fix it.

================
Comment at: lib/sanitizer_common/sanitizer_stacktrace.h:22
@@ -21,4 +21,3 @@
 
-#if SANITIZER_LINUX && (defined(__aarch64__) || defined(__sparc__) || \
-                        defined(__mips__))
+#if SANITIZER_LINUX &&  (defined(__sparc__) || defined(__mips__))
 # define SANITIZER_CAN_FAST_UNWIND 0
----------------
eugenis wrote:
> Oh, are you saying the current fast unwind implementation simply works on aarch64? Nice.
I saw no regressions or failures tests that indicate otherwise. In fact it fixes 'MemorySanitizer :: fork.cc' which stucks in _Unwind_Backtrace from libgcc with SlowUnwinder.


http://reviews.llvm.org/D12709