[PATCH] D12709: [PATCH] [sanitizers] [msan] Enable MSAN for aarch64

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 15:12:15 PDT 2015


eugenis added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:332
@@ -323,1 +331,3 @@
+#endif
+#if defined(PT_GETREGS) && defined(PT_SETREGS)
   int ptrace_getfpregs = PTRACE_GETFPREGS;
----------------
did you mean PT_GETFPREGS here and PT_GETFPXREGS below?

================
Comment at: lib/sanitizer_common/sanitizer_stacktrace.h:22
@@ -21,4 +21,3 @@
 
-#if SANITIZER_LINUX && (defined(__aarch64__) || defined(__sparc__) || \
-                        defined(__mips__))
+#if SANITIZER_LINUX &&  (defined(__sparc__) || defined(__mips__))
 # define SANITIZER_CAN_FAST_UNWIND 0
----------------
Oh, are you saying the current fast unwind implementation simply works on aarch64? Nice.


http://reviews.llvm.org/D12709





More information about the llvm-commits mailing list